Nate Butler
9ce7199d2d
Add some initial docs
2023-11-03 18:19:54 -04:00
Marshall Bowers
5d36331942
storybook2: Remove unreferenced components
module ( #3229 )
...
This PR removes the `components` module from `storybook2` as it was
dead, unreferenced code.
Release Notes:
- N/A
2023-11-03 18:12:21 -04:00
Julia
3834e26f71
Tooltips in mouse event handler & fix executor timer
...
Co-Authored-By: Conrad Irwin <conrad@zed.dev>
2023-11-03 18:02:58 -04:00
Marshall Bowers
76db100d11
ui2: Reorganize components ( #3228 )
...
This PR reorganizes the components in the `ui2` crate.
The distinction between "elements" and "components" is now gone, with
all of the reusable components living under `components/`.
The components that we built while prototyping but will eventually live
in other crates currently reside in the `to_extract/` module.
Release Notes:
- N/A
2023-11-03 17:34:11 -04:00
Marshall Bowers
287ea0a6e4
Allow deriving Serialize
and Deserialize
on generated refinement ( #3227 )
...
This PR adds support for deriving `Serialize` and `Deserialize` on the
refinement type generated by `#[derive(Refineable)]`.
Release Notes:
- N/A
2023-11-03 17:21:00 -04:00
Marshall Bowers
b5224bdafd
Remove unneeded type qualification
2023-11-03 16:40:46 -04:00
Nate Butler
d500b01aed
Add docs burndown list
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-03 16:37:22 -04:00
Marshall Bowers
1361b61708
Use an IconButton
for the tab close button
2023-11-03 16:36:02 -04:00
Nate Butler
740e2cc5bf
Start on ui root doc
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-03 16:28:54 -04:00
Conrad Irwin
f97046b86f
MOAR TOOLTIPS
2023-11-03 14:15:32 -06:00
Kirill Bulatov
edacffab58
Refresh diagnostics inside the tab ( #3225 )
...
r-a now has 2 different types of diagnostics:
* "disk-based" ones that come from `cargo check` and related, that emit
`project::Event::DiskBasedDiagnosticsStarted` and
`DiskBasedDiagnosticsFinished`
* "flycheck" diagnostics from r-a itself, that it tries to dynamically
apply to every buffer open, that come with `DiagnosticsUpdated` event.
Latter diagnostics update frequently, on every file close and open, but
`diagnostics.rs` logic had never polled for new diagnostics after
registering the `DiagnosticsUpdated` event, so the only way we could
have newer diagnostics was to re-open the whole panel.
The PR fixes that, and also adds more debug logging to the module.
The logic of the fix looks very familiar to previous related fix:
https://github.com/zed-industries/zed/pull/3128
One notable thing after the fix: "flycheck" diagnostics stay forever if
the diagnostics panel is opened: excerpts in that panel do not allow the
buffer to get dropped (hence, closed in terms of r-a) and get the
updated, zero diagnostics.
If the diagnostics panel is opened and closed multiple times, those
errors gradually disappear.
Release Notes:
- Fixed diagnostics panel not refreshing its contents properly
2023-11-03 22:03:05 +02:00
Conrad Irwin
33245d119e
Tooltip on tabs
...
Co-Authored-By: Julia <julia@zed.dev>
2023-11-03 14:02:46 -06:00
Kirill Bulatov
918d123284
Fix the test
2023-11-03 21:51:12 +02:00
Kirill Bulatov
6f8947a3d3
Fix a compilation error
2023-11-03 21:51:12 +02:00
Kirill Bulatov
9cb8ce172d
Refresh diagnostics inside the tab
2023-11-03 21:51:12 +02:00
Marshall Bowers
12500364b4
Merge branch 'main' into import-theme
2023-11-03 15:41:12 -04:00
Marshall Bowers
fa7d6c0e70
Remove Default
impl for
ThemeColors` ( #3226 )
...
This PR removes the `Default` impl for `ThemeColors`.
Since we need default light and dark variants for `ThemeColors`, we
can't use a single `Default` impl.
Release Notes:
- N/A
2023-11-03 15:40:50 -04:00
Max Brunsfeld
66499f60ee
Fix double borrow in synchronous tests that take AppContext
...
Co-authored-by: Mikayla <mikayla@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
2023-11-03 12:10:11 -07:00
Mikayla
2b883bf32e
WIP
2023-11-03 12:04:24 -07:00
Conrad Irwin
26e64fb843
gpui2: Add on_hover events
2023-11-03 12:51:38 -06:00
Antonio Scandurra
2a672e2126
WIP
2023-11-03 18:55:20 +01:00
Mikayla
6a1fb18334
Update to latest patterns for porting work
2023-11-03 10:46:47 -07:00
Max Brunsfeld
b085569b46
Add channel2 crate
...
Co-authored-by: Marshall <marshall@zed.dev>
2023-11-03 10:41:41 -07:00
Conrad Irwin
d73c54f604
Add PointingHand on tabs
2023-11-03 11:30:15 -06:00
Conrad Irwin
c604a2e34e
Add hover behaviour to tabs
...
Co-Authored-By: Marshall <marshall@zed.dev>
Co-Authored-By: Nathan <nathan@zed.dev>
2023-11-03 10:55:07 -06:00
Antonio Scandurra
d3b02c4de4
WIP: start on editor element
2023-11-03 17:14:17 +01:00
Conrad Irwin
580694dbda
Fix bug when unsubscribe called after remove
...
Co-Authored-By: Julia <julia@zed.dev>
2023-11-03 09:56:35 -06:00
Conrad Irwin
920ea1bf0a
Make the close button close
2023-11-03 09:20:27 -06:00
Antonio Scandurra
b5c2cf371a
Ensure panes cover the available space
2023-11-03 16:14:03 +01:00
Conrad Irwin
0edcec7c4e
Fix tab text colors
2023-11-03 09:12:12 -06:00
Marshall Bowers
363d7c6634
Exclude source themes from Zed2 binary
2023-11-03 11:11:10 -04:00
Kyle Caverly
343525d77b
added workspace event for WorkspaceCreated ( #3222 )
...
added workspace2 event for WorkspaceCreated
Release Notes:
- NA
2023-11-03 11:06:11 -04:00
Marshall Bowers
acc36e6dab
Update emitted module import
2023-11-03 10:58:06 -04:00
Marshall Bowers
293fbe4c75
Account for colors in VS Code theme being optional
2023-11-03 10:54:12 -04:00
Antonio Scandurra
b21c25826d
Make tab bar visible
2023-11-03 15:51:33 +01:00
Marshall Bowers
e0382a61b9
Update color names in workspace2
2023-11-03 10:16:34 -04:00
Marshall Bowers
a7edd380e3
Merge branch 'main' into import-theme
2023-11-03 10:11:35 -04:00
Antonio Scandurra
de3d37e070
Don't depend on gpui2 in text
2023-11-03 14:53:08 +01:00
Antonio Scandurra
097171b9b8
Merge remote-tracking branch 'origin/main' into editor2
2023-11-03 14:47:49 +01:00
Antonio Scandurra
3e8fcefaef
Remove more todos
2023-11-03 14:42:26 +01:00
Antonio Scandurra
feaab953a8
Add ViewContext::window_context
2023-11-03 14:41:37 +01:00
KCaverly
b148c61047
added workspace event for WorkspaceCreated
2023-11-03 08:52:18 -04:00
Kirill Bulatov
1a0cd3e09b
Remove and add more todosmerge .
2023-11-03 13:22:11 +02:00
Antonio Scandurra
77e3c7f8ee
WIP
2023-11-03 12:10:15 +01:00
Kirill Bulatov
f1fc07de94
Move journal2 to workspace2
2023-11-03 12:55:06 +02:00
Kirill Bulatov
eb8a0e7148
Uncomment persistence tests
2023-11-03 12:38:09 +02:00
Antonio Scandurra
b7712c2f4b
Fix a todo in workspace
2023-11-03 11:36:39 +01:00
Antonio Scandurra
bed10b433a
Allow converting from a WeakView<V> to an AnyWeakView
2023-11-03 11:36:18 +01:00
Antonio Scandurra
6fc7b17259
Expose a focus handle from workspace::Item
2023-11-03 11:00:57 +01:00
Antonio Scandurra
97d1d9bd9b
Uncomment Editor::report_editor_event
2023-11-03 10:53:55 +01:00
Antonio Scandurra
0dfa3c60b7
Remove some todos
2023-11-03 10:50:30 +01:00
Antonio Scandurra
11feda01e3
Uncomment Editor::new
2023-11-03 10:38:28 +01:00
Antonio Scandurra
2fccde5ab6
Remove unused code
2023-11-03 10:11:13 +01:00
Antonio Scandurra
efa27cf9b8
Uncomment more editor code
2023-11-03 10:09:00 +01:00
Kirill Bulatov
09346fb9f1
Port changes to zed2
2023-11-03 11:02:50 +02:00
Kirill Bulatov
24dd1c5812
Properly order default prettier installations and startups
2023-11-03 11:02:50 +02:00
Kirill Bulatov
244c693968
Reuse already running default prettiers
2023-11-03 11:02:50 +02:00
Kirill Bulatov
cf95f9b082
Make it more clear that missing prettier is to blame
2023-11-03 11:02:50 +02:00
Kirill Bulatov
369b5140fb
Restore LSP names for prettier servers
2023-11-03 11:02:50 +02:00
Kirill Bulatov
b75d8a60a8
Simplify
2023-11-03 11:02:50 +02:00
Kirill Bulatov
ff144def63
Fix the bugs
2023-11-03 11:02:50 +02:00
Kirill Bulatov
6bbb79a9f5
Rework prettier installation and start
2023-11-03 11:02:50 +02:00
Kirill Bulatov
d673efebd2
Add prettier workspace resolution test
2023-11-03 11:02:50 +02:00
Antonio Scandurra
cdc82d01f7
Call editor::init
2023-11-03 09:06:25 +01:00
Antonio Scandurra
800c2685ea
Remove dependency from gpui from editor2
2023-11-03 09:05:58 +01:00
Nathan Sobo
fbee6b5352
Get editor2 compiling with a ton of code commented out
2023-11-02 23:35:20 -06:00
Nathan Sobo
f3b8a9d8c2
WIP
2023-11-02 22:56:04 -06:00
Nathan Sobo
a731f8fb1e
WIP
2023-11-02 21:28:56 -06:00
Nathan Sobo
dfc7c81500
WIP
2023-11-02 21:03:29 -06:00
Nathan Sobo
72b9dc8216
Merge remote-tracking branch 'origin/main' into editor2
2023-11-02 20:47:09 -06:00
Nathan Sobo
6a89f7ce4f
rich text2 ( #3220 )
...
- git -> git3
- Add rich_text2
[[PR Description]]
Release Notes:
N/A
2023-11-02 20:46:45 -06:00
Nathan Sobo
2a12e8f307
Merge remote-tracking branch 'origin/rich_text2' into editor2
2023-11-02 20:34:52 -06:00
Nate Butler
383d9129f4
[Not compiling] Continue working on VSCode import
2023-11-02 21:49:26 -04:00
Conrad Irwin
0b3932f38c
Convert rich_text2
2023-11-02 19:30:33 -06:00
Conrad Irwin
6ecb4805f7
Add rich_text2
2023-11-02 19:19:18 -06:00
Conrad Irwin
cbd902658c
git -> git3
...
This is needed for the editor.
2023-11-02 19:18:01 -06:00
Conrad Irwin
0aabb19a45
Into the woods
2023-11-02 18:52:08 -06:00
Nate Butler
b4e2368943
Merge branch 'main' into import-theme
2023-11-02 20:16:09 -04:00
Nate Butler
0d0b6db24f
Update theme importer
2023-11-02 20:15:51 -04:00
Nate Butler
2b0c959137
Add terminal colors to ThemeColors, add _background
to some color names.
2023-11-02 19:53:52 -04:00
Nathan Sobo
9052b48949
Use correct color values in quad fragment shader ( #3217 )
...
Previously, when using rounded corners, the borders would get wider.
Looks like we weren't using the input color values consistently in the
fragment shader. The quad values are raw HSLA and are converted in the
vertex shader.
Release Notes:
- N/A
2023-11-02 17:49:56 -06:00
Marshall Bowers
95a0827517
Clean up unused code
2023-11-02 19:20:21 -04:00
Marshall Bowers
152ac6927f
Add themes2/src/themes
directory
2023-11-02 19:17:39 -04:00
Marshall Bowers
d1636bf16b
Finish up theme printer
2023-11-02 19:14:51 -04:00
Marshall Bowers
fc376287e0
Start work on theme printer
2023-11-02 18:57:13 -04:00
Nathan Sobo
7b712ac68f
WIP
2023-11-02 16:47:14 -06:00
Marshall Bowers
0bc51382b2
Add basic VsCodeThemeConverter
2023-11-02 18:24:38 -04:00
Marshall Bowers
e48332c81f
Parse VSCode theme files
2023-11-02 18:00:55 -04:00
Conrad Irwin
583c36e24b
WIP
2023-11-02 15:27:49 -06:00
Nate Butler
058981350c
Scaffold out new theme-importer
crate
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-02 17:21:11 -04:00
Conrad Irwin
09efa017d4
Editor2
2023-11-02 14:36:42 -06:00
Conrad Irwin
9e5275cc18
Fix error handling of open_path
...
Co-Authored-By: Nathan <nathan@zed.dev>
2023-11-02 14:34:43 -06:00
Nate Butler
972f076b4d
Deserialize theme metadata
2023-11-02 16:31:22 -04:00
Nate Butler
58ac7f2926
[Broken] Load a src theme in test
2023-11-02 16:26:27 -04:00
Marshall Bowers
54969877a4
Make the Zed2 window movable ( #3218 )
...
This PR makes the Zed2 window movable and fixes a crash related to a
`todo!()` that wasn't necessary.
Release Notes:
- N/A
2023-11-02 16:17:31 -04:00
Conrad Irwin
8283909dfd
Disable selective warnings to make cargo check happy
2023-11-02 13:28:58 -06:00
Nathan Sobo
91f3e9707a
Use correct color values in quad fragment shader
...
Co-Authored-By: Julia Risley <julia@zed.dev>
2023-11-02 13:18:20 -06:00
Conrad Irwin
269a72464d
Merge remote-tracking branch 'origin/main' into zed2-workspace
2023-11-02 13:16:24 -06:00
Mikayla Maki
85f0959548
Remove the 2s from source code ( #3216 )
...
Release Notes:
- N/A
2023-11-02 12:11:16 -07:00
Marshall Bowers
9c8220d04e
Remove commented-out label code
2023-11-02 15:04:52 -04:00